Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite follow up #2823

Open
1 of 2 tasks
RunDevelopment opened this issue Apr 27, 2024 · 0 comments
Open
1 of 2 tasks

Vite follow up #2823

RunDevelopment opened this issue Apr 27, 2024 · 0 comments
Labels
enhancement New feature or request GUI Issue or PR for the electron app

Comments

@RunDevelopment
Copy link
Member

RunDevelopment commented Apr 27, 2024

With vite (#2781) in, there are a few things that we should change to take full advantage of the new infrastructure:

  • Make our components compatible with react refresh. We can use eslint-plugin-react-refresh to verify this.
  • Improve the preload script and IPC. We currently give direct IPC access to the renderer, which is an anti-pattern. We need to rethink how we communicate with the main process. Ideally, we could also take this chance to simply the API. E.g. we have a lot of ICP channels for getting constants from the main process (e.g. app version). We could potentially already load those values in the preload script, which would simplify frontend code since we no longer have to asynchronously access them.
@RunDevelopment RunDevelopment added enhancement New feature or request GUI Issue or PR for the electron app labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI Issue or PR for the electron app
Projects
None yet
Development

No branches or pull requests

1 participant