Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homography-based image alignment #2791

Open
Splendide-Imaginarius opened this issue Apr 12, 2024 · 3 comments
Open

Homography-based image alignment #2791

Splendide-Imaginarius opened this issue Apr 12, 2024 · 3 comments

Comments

@Splendide-Imaginarius
Copy link
Contributor

Continuing from @pifroggi's comment at #2714 (comment)

My thinking with mentioning Rife in the name was in case in the future different kinds of alignment methods are added. For example it may make sense to add a traditional affine alignment method at some point, which would be better with images that are off by a lot, which could then be refined by this method. But maybe it makes more sense to think about that if it happens. What do you think?

I have an implementation of OpenCV-based image alignment (based on a homography matrix) here: https://github.com/Splendide-Imaginarius/subimage-stitcher

It works pretty well; would there be interest in a PR that adds a chaiNNer node with that implementation (subject to whatever code quality cleanup is needed to meet chaiNNer standards)? As @pifroggi observed, it might complement the RIFE implementation.

@joeyballentine
Copy link
Member

Yes, that would be nice if you wouldn't mind. I still would like it to not be a separate node but rather have a "rife" and a "homography" mode on the one node.

@Splendide-Imaginarius
Copy link
Contributor Author

Yes, that would be nice if you wouldn't mind. I still would like it to not be a separate node but rather have a "rife" and a "homography" mode on the one node.

@joeyballentine I see why that's desirable in the general case, but isn't there some precedent in chaiNNer for using separate nodes for PyTorch-based stuff versus non-NN stuff (I guess so that dependency checking works properly)?

@joeyballentine
Copy link
Member

Oooooh, right. Yes, leave it separate then. My bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants