Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text in GUI is not visible in dark mode in Mac OS. #96

Open
chingyulin opened this issue Aug 27, 2022 · 6 comments
Open

The text in GUI is not visible in dark mode in Mac OS. #96

chingyulin opened this issue Aug 27, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@chingyulin
Copy link
Collaborator

Describe the bug
The text in GUI is not visible in dark mode in Mac OS.

To Reproduce
Steps to reproduce the behavior:

  1. Go to System Preference
  2. Click on General
  3. In Appearance, click Dark
  4. See error in the labelCloud GUI

Expected behavior
The text should be visible in dark mode.

Screenshots
image
Desktop (please complete the following information):

  • macOs Monterey 12.5
  • Python 3.8.9

Additional context
Add any other context about the problem here.

@ch-sa ch-sa added the bug Something isn't working label Aug 28, 2022
@ch-sa
Copy link
Owner

ch-sa commented Aug 28, 2022

Oh, seems like they just overwrite the default font color with white. I am surprised they do that without (to my knowledge) the app stating it supports dark mode.

I would try to set the default color explicitly to black for all elements and see if that helps.

Correctly supporting dark mode would than be a new feature.

Thanks for raising the issue.

ch-sa added a commit that referenced this issue Aug 28, 2022
 - globally set font color to black

Closes: #96
@ch-sa
Copy link
Owner

ch-sa commented Aug 28, 2022

Hi @chingyulin,

I added a branch with the above described fix:
sager/fix-max-darkmode

Could you install and try it, cause I don't have access to a Mac right now...

@chingyulin
Copy link
Collaborator Author

Thanks for the quick response and attempt. Unfortunately, the bug still persists with the fix. :(

  • This bug is not blocking me tho as it works with light mode.

@ch-sa
Copy link
Owner

ch-sa commented Aug 28, 2022

To bad.

I am not sure how MacOS is applying the styles. But apparently overwriting them on the app level doesn't help.

Maybe you can have a look if you find some time cause it's easier to test for you.

@chingyulin
Copy link
Collaborator Author

Sure, it makes sense that I check it. Just so you and others know, I'll prioritize the segmentation feature for now unless more users complain about this.

@luvwinnie
Copy link

I have this problem too, is this already fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants