Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSE] Documentation/Readme possible improvements #20

Open
BenjMy opened this issue Dec 19, 2022 · 2 comments
Open

[JOSE] Documentation/Readme possible improvements #20

BenjMy opened this issue Dec 19, 2022 · 2 comments

Comments

@BenjMy
Copy link

BenjMy commented Dec 19, 2022

xref openjournals/jose-reviews#185

  • README

    • Make clear that Gempy is an optional dependency in the README.
    • Identify the target audience in the docs and in the README.
    • Add briefly FAIR principles adopted for the datasets
  • Documentation:

    • The installation section is a bit confusing. I would only add 2 clear installations: (1) Installing using Conda/Pip (2) Installation of a developer version. Particularly I don't understand why you recommend "installing Gemgis dependencies manually" after "Installing GemGIS via conda-forge". I would expect the required dependencies installed automatically.
      Notebooks recommandations
@jwagemann
Copy link

  • The repository misses a description on dependencies and environment settings via e.g. an environment.yml file → how can I replicate the setup to have the notebooks of the tutorial running?
  • The link to the binder does not open an environment where I can run the tutorial notebooks → it leads to the GemGIS binder setup
  • I cannot see a version indicated on the repository
  • License of repository (GPL 3.0) and license identified on the notebooks (CC-BY) differ

@AlexanderJuestel
Copy link
Collaborator

AlexanderJuestel commented Jan 15, 2023

Also, here a list of your comments to track my progress of the revision:

  • Make clear that Gempy is an optional dependency in the README.

  • Identify the target audience in the docs and in the README.

  • Add briefly FAIR principles adopted for the datasets

  • The installation section is a bit confusing. --> Fixing the installation

  • I often found very useful to have a button to be able to download the notebook directly from the documentation (see Sphinx doc).

  • The repository misses a description on dependencies

  • The repository misses a description environment settings via e.g. an environment.yml file → how can I replicate the setup to have the notebooks of the tutorial running?

  • The link to the binder does not open an environment where I can run the tutorial notebooks → it leads to the GemGIS binder setup

  • I cannot see a version indicated on the repository

  • License of repository (GPL 3.0) and license identified on the notebooks (CC-BY) differ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants