Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] [UnifiedMap] Change of routing style shows no effect - until GPS position changes #15652

Open
MagpieFourtyTwo opened this issue Apr 21, 2024 · 4 comments
Labels
Bug Issues classified as a bug Map: Unified Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility
Projects

Comments

@MagpieFourtyTwo
Copy link

Describe your problem!

Admittedly, it may be a bit hard to reproduce, but after using c:geo for a while, changing the routing style seems to show no effect at all anymore. After a few hours the background re-routing (because of style change) takes up to 60(!) seconds until the new route is displayed on the map. And this applies even to style "straight line".

Even worse: Sometimes it does not appear at all, even after several minutes. And even after a fresh restart it takes extraordinary long, especially if you change the style multiple times. Over here, already the third change took 15 seconds to recalculate - while "route" is even kind of exaggerated, as the currently tested target is just 2 km away ...

How to reproduce?

  1. Open Unified Life Map
  2. chose any cache and route to it by clicking the bottom sheet's nav button
  3. after route is displayed, use bottom sheet to change the routing style
  4. repeat 3. for a few times ...

Actual result after these steps?

  1. no matter which routing style will been chosen, even "re-calculation" of "straight line" will take really long at some point (about 30 seconds up to ... uncounted)

Expected result after these steps?

Re-Routing should take place within seconds. And in my tested distances within a fraction of a second.

Reproducible

Yes

c:geo Version

2024.04.21-NB-be2d1b4

System information

No response

Additional Information

No response

@MagpieFourtyTwo MagpieFourtyTwo added Bug Issues classified as a bug Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility labels Apr 21, 2024
@moving-bits
Copy link
Member

have not been able yet to reproduce this in the emulator, even though I have a pretty slow one today, and I switched routing style about 20 times between the four modes for a route of app. 6 km (three items + route from current position)

@moving-bits moving-bits added this to To do in Unified map via automation Apr 26, 2024
@MagpieFourtyTwo
Copy link
Author

Although routing was extremely "stubborn" that day, it hasn't happened since.
I'll keep an eye on it, maybe I can get a more reproducible scenario.

@MagpieFourtyTwo
Copy link
Author

MagpieFourtyTwo commented May 1, 2024

New finding: Recalculation (resp. refresh in map) will not happen, until current GPS location changes.

Of course it doesn't matter if the change has happened because of signal hopping or real position changes, but if you (or your signal) don't move, you will wait forever, the route will not be updated in map.

Absolutely reproducible scenario (at least over here):

  1. Open unified map and route to any cache
  2. Either stand still :) or disable GPS
  3. Change routing style
  4. Toast of background recalculation will appear, but apart from the routing style symbol no updates will happen in map, neither routing line nor distance will change
  5. Move a bit :) or enable GPS
  6. After a few seconds the new route will be displayed

BTW: Performing the same with individual route between two manual targets works perfectly fine. Guess there is an explicit refresh after changing the routing style.

@MagpieFourtyTwo
Copy link
Author

MagpieFourtyTwo commented May 1, 2024

New finding: Recalculation (resp. refresh in map) will not happen, until current GPS location changes.

Of course it doesn't matter if the change has happened because of signal hopping or real position changes, but if you (or your signal) don't move, you will wait forever, the route will not be updated in map.

Absolutely reproducible scenario (at least over here):

  1. Open unified map and route to any cache
  2. Either stand still :) or disable GPS
  3. Change routing style
  4. Toast of background recalculation will appear, but apart from the routing style symbol no updates will happen in map, neither routing line nor distance will change
  5. Move a bit :) or enable GPS
  6. After a few seconds the new route will be displayed

BTW: Performing the same with individual route between two manual targets works perfectly fine. Guess there is an explicit refresh after changing the routung style.

Addendum: With GPS active and de facto no (real) position changes at all, there are a lot of unneeded refreshes (and most probably even route recalculations, I guess) which make the route flicker (and most probably waste a lot of energy, too). Looks as if there is a recalculation on every single location change, even after the smallest. Wouldn't it be possible to add a minimum location delta (perhaps depending on accuracy circle) until next recalculation or update takes place? The way it is now looks a bit ... nervous. :) And in the very most cases a few meters plus or minus will not change the route in a senseful way anyway, IMHO.

@MagpieFourtyTwo MagpieFourtyTwo changed the title [Nightly] [UnifiedMap] Change of routing style shows no effect (or takes incredibly long) [Nightly] [UnifiedMap] Change of routing style shows no effect - until GPS position changes May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues classified as a bug Map: Unified Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility
Projects
Unified map
  
To do
Development

No branches or pull requests

2 participants