Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit / Delete TB log #15641

Open
ztNFny opened this issue Apr 18, 2024 · 4 comments
Open

Edit / Delete TB log #15641

ztNFny opened this issue Apr 18, 2024 · 4 comments
Labels
Connector GC gc.com specific issue Feature Request A request for a new feature/function Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility

Comments

@ztNFny
Copy link
Contributor

ztNFny commented Apr 18, 2024

Tell us your idea!

During my tests of the logging fixes I realized only cache logs can be edited/deleted. Same option should exist for TB logs. GC connector only.

What solution would you suggest?

No response

Is there an alternative?

No response

Additional Information

No response

@ztNFny ztNFny added Feature Request A request for a new feature/function Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility Connector GC gc.com specific issue labels Apr 18, 2024
@Lineflyer
Copy link
Member

If someone starts working on this:
Maybe we could also reuse the existing image upload functions to also implement them for TB logs: #7064

@bekuno
Copy link
Member

bekuno commented Apr 22, 2024

The TB log edit/delete function is implemented and fails in the same way as the cache log, see #15633 (comment)

@eddiemuc
Copy link
Contributor

The TB log edit/delete function is implemented and fails in the same way as the cache log, see #15633 (comment)

IIRC I implemented only "delete log" for TBs, not "edit log". (Also "delete log" is not available to the user in GUI, but I needed it for the unit tests for cleanup)

@ztNFny
Copy link
Contributor Author

ztNFny commented Apr 22, 2024

I briefly looked into this and realized why it's not yet implemented: The connectors don't have flags to indicated whether logs can be deleted, edited, images uploaded. So TrackableConnector and all its implementations need to be expanded, then Trackable does.
Then we need a way to retrieve the TrackableConnector from logging - Geocache is retrieved from DataStore, but that one usually doesn't have the Trackable at that point, so it needs to be saved there first.
Only then the UI can be shown- which is the easy part.

It's not complicated, but for sure it's a lot of work to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector GC gc.com specific issue Feature Request A request for a new feature/function Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility
Projects
None yet
Development

No branches or pull requests

4 participants