New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh map data after opening / closing settings dialog #15659
base: master
Are you sure you want to change the base?
Refresh map data after opening / closing settings dialog #15659
Conversation
@eddiemuc / @moving-bits please check if my assumption and fix is correct |
Could you trigger the reload only if a relevant setting has changed? Changing e.g. navigation mode shouldn't trigger the reload. |
Thought about that already, but the only changed-info is about the circles. I will try, if I can find an easy way to transport/ transfer the information, if a setting is changed, which needs to update the map-data... |
Probably I can check the resulting filter.... |
I tried to check, if the relevant checkboxes changed values and only in this case reload the caches / trigger a new search |
@eddiemuc / @moving-bits can someone has a look on it please... |
Description
With my limited understanding of the BackgroundHandler and loading caches - but with debugging and trying:
If no
loadInBackgroundHandler
is set, then the caches / waypoints have to be reloaded viareloadCachesAndWaypoints
to adapt to the possible changes made in the settings-popup.Reloading and recreating the loadInBackgroundHandler is only done, if the relevant settings have changed.
Therefore I enhanced the
SettingsCheckboxModel
with the possibility to get that information.Related issues
fix #15611
fix #15614
fix #15661
Additional context