Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License notices for derived code #249

Open
iebold opened this issue Aug 8, 2023 · 1 comment
Open

License notices for derived code #249

iebold opened this issue Aug 8, 2023 · 1 comment

Comments

@iebold
Copy link

iebold commented Aug 8, 2023

I see various references in the source code for places that were the original work, usually under MIT.

Eg. https://github.com/cfworker/cfworker/blob/main/packages/json-schema/src/ucs2-length.ts mentions https://github.com/bestiejs/punycode.js

https://github.com/cfworker/cfworker/blob/main/packages/json-schema/src/format.ts mentions https://github.com/epoberezkin/ajv/blob/master/lib/compile/formats.js (which is basically https://github.com/ajv-validator/ajv )

Thing is, each of this original works have their own MIT license which grant you the right to modify it as long as you keep the notice. But none of the original notices are included as far as I can tell. See, eg. https://github.com/mathiasbynens/punycode.js/blob/main/LICENSE-MIT.txt

@jdanyow
Copy link
Member

jdanyow commented Aug 9, 2023

good call @iebold, would you be willing to send a pr to resolve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants