Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @cfworker/sentry to prepareStackTrace #179

Open
jdanyow opened this issue Dec 17, 2021 · 2 comments
Open

Migrate @cfworker/sentry to prepareStackTrace #179

jdanyow opened this issue Dec 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jdanyow
Copy link
Member

jdanyow commented Dec 17, 2021 •
edited

https://github.com/errwischt/stacktrace-parser/blob/master/src/stack-trace-parser.js
https://v8.dev/docs/stack-trace-api
@jdanyow jdanyow added the enhancement New feature or request label Dec 17, 2021
@nikosgpet
Copy link

I am not getting it. Why manually parse the stack instead of using the V8 stack trace API as done here: https://github.com/borderless/worker-sentry/blob/master/src/index.ts

@jdanyow
Copy link
Member Author

jdanyow commented Jan 23, 2022

Ha simple- I didn't know about the prepareStackTrace trick- thanks for the tip 🤙

@jdanyow jdanyow changed the title Migrate @cfworker/sentry to stacktrace-parser Migrate @cfworker/sentry to the prepareStackTrace hack Jan 23, 2022
@jdanyow jdanyow changed the title Migrate @cfworker/sentry to the prepareStackTrace hack Migrate @cfworker/sentry to prepareStackTrace Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdanyow @nikosgpet