Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update Yarn and Node #426

Open
billhimmelsbach opened this issue Apr 28, 2024 · 0 comments
Open

[Task] Update Yarn and Node #426

billhimmelsbach opened this issue Apr 28, 2024 · 0 comments
Assignees

Comments

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Apr 28, 2024

Found this bug when trying to run tests locally:

Screenshot 2024-04-27 at 4 43 24 PM

This bug is caused by running on an old version of node on older versions of yarn, which has been fixed in later updates. Updating to the latest version of yarn fixes this issue (the DS did it earlier), but v4 of yarn also requires at least node 18. We should at least update from node 16 to node 18 anyway for the engine, since it's at EOL. We could also update all the way to node 20, or even 22 if we're ok with it not being a LTS release for a few months. We can probably wait till post-mvp for that change.

I want to check to make sure this is ok with how the DDD is written before updating though.

Current behavior

  • yarn is at v3
  • node is at v16

Expected behavior

  • yarn is at v4
  • node is at 18, maybe even 20/22 post-mvp if we're ok not being on a LTS release for a few months
@billhimmelsbach billhimmelsbach self-assigned this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant