Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Metrics recording: Only run request timer for valid requests #189

Open
marcesher opened this issue Mar 11, 2014 · 3 comments
Open

Metrics recording: Only run request timer for valid requests #189

marcesher opened this issue Mar 11, 2014 · 3 comments

Comments

@marcesher
Copy link
Contributor

Currently, we wrap every request with a with-timing call based on the request path, so that we can capture per-slice metrics. However, this has a nasty side effect of also recording metrics for any invalid requests.

We should limit the with-timing calls to only valid, non-400 requests

@marcesher marcesher added the bug label Mar 11, 2014
@marcesher
Copy link
Contributor Author

the problem here is with the current location of the metrics call. Because the request hasn't yet completed, it doesn't have access to status information. Consequently, this will need to be decoupled from the current per-request logging, or else that information will somehow need to be made available to that function

@m3brown

@mushketyk
Copy link
Contributor

I would like to work on this.
Is it still relevant?

@marcesher
Copy link
Contributor Author

@mushketyk Thanks! Definitely still relevant. I can't promise an immediate response to pull requests, but we'll do our best.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants