Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics and Tag IDs should be in environment var #495

Open
anselmbradford opened this issue Apr 29, 2015 · 1 comment
Open

Google Analytics and Tag IDs should be in environment var #495

anselmbradford opened this issue Apr 29, 2015 · 1 comment

Comments

@anselmbradford
Copy link
Member

anselmbradford commented Apr 29, 2015

Google Analytics ID is pegged against .consumerfinance.gov addresses, which appears like it'll conflate beta.cf.gov and www.cf.gov traffic together.

https://github.com/cfpb/consumerfinance.gov/blob/master/cfgov/jinja2/v1/_layouts/base.html#L216

This also makes it so any forks of this project need to go in and edit hardcoded values. Instead I'd suggest we aim for a centralized config file of some sort for customizing project credentials of this sort.

Additionally, Google Tag Manager should have the same configuration. This PR highlights how easy it is to miss when the wrong environment credentials are used because they are buried in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants