Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by category should require a page type #1445

Open
richaagarwal opened this issue Feb 11, 2016 · 1 comment
Open

Filter by category should require a page type #1445

richaagarwal opened this issue Feb 11, 2016 · 1 comment

Comments

@richaagarwal
Copy link
Contributor

Currently, you can select "Filter category", but not a "Page type", as shown:

screen shot 2016-02-11 at 1 49 40 pm

and successfully save the page, but it will error out when you try to view the page because there's no page type. We should add validation here.

@chosak
Copy link
Member

chosak commented Sep 29, 2023

This no longer errors when you view the page, but it shows up as an empty category list:

image

We could add validation to ensure that users have to select a list of categories if they want to filter by category; a simpler UI would probably be to only show the dropdown, and hide the category filter unless an option was selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants