Update README.md #476
Update README.md #476
Conversation
There was a problem hiding this comment.
Thanks for the work on the README.
I've suggested a couple changes.
This is not an urgent issue, and since @flacoman91 did the bulk of recent work on ccdb5-ui, I'd like to give him a chance to review. That could take a while, as he's on an extended leave.
README.md
Outdated
| 1. [Capital Framework](https://cfpb.github.io/capital-framework/) - CFPB standard styling and controls | ||
| 1. [History](https://github.com/reacttraining/history) - Integrating the address bar with the application | ||
| 1. [dayjs](https://day.js.org/) - Better date handling than native JavaScript | ||
| For detailed information about the design system and its underlying components, please refer to the official [Design System Documentation](https://thedesignsystem.guide/documentation). The design system provides standardized styling, controls, and guidelines, ensuring a unified user experience throughout the application. |
There was a problem hiding this comment.
This is not the design system we use. The CFPB has its own design system:
https://cfpb.github.io/design-system/
There was a problem hiding this comment.
Also, I think I'd dial back the verbiage on the design system. We don't need to sell it.
There was a problem hiding this comment.
ok then i will make the suggested changes.
Co-authored-by: william higgins <higs4281@users.noreply.github.com>
|
hey @higs4281 can you merge it by the month end as I am participating in hacktoberfest. |
|
My apologies!
I'm out on parental leave til Jan 23, but Ans Bradford or Contolini would
have more recent experience with ccdb5-ui.
I haven't touched the code base in a really long time.
…On Thu, Oct 26, 2023, 2:38 PM kiranrokkam09 ***@***.***> wrote:
hey @higs4281 <https://github.com/higs4281> can you merge it by the month
end as I am participating in hacktoberfest.
—
Reply to this email directly, view it on GitHub
<#476 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5PYRT5PVGJJF2TRCFFK3YBKUZDAVCNFSM6AAAAAA6PZBSG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGY3DINBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@contolini @anselmbradford can you look into my pr and merge it by the month end as I am participating in hacktoberfest. |
|
Hi @kiranrokkam09! 👋 @contolini mentioned to me that you were looking to make contributions for Hacktoberfest, which is awesome! If you're interested in a small React issue, I made a testing issue for you in our repo dedicated to implementing the CFPB design in React. It's a request for a few tests to check if styles are being rendered properly for one of our new components. No pressure, but I wanted you to have every opportunity to contribute to the CFPB this month. Thanks! |
|
Thanks for this PR @kiranrokkam09. It has a handful of problems so I'm going to close it. If you'd like to help out with our design system, check out the issue @billhimmelsbach linked to above. 🎃 |
Updated the outdated readme file. Just leaving one portion "Update information about unit testing".
Fixes: #455
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist