Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile new Typo.js version? #54

Open
connor4312 opened this issue Dec 14, 2016 · 2 comments
Open

Reconcile new Typo.js version? #54

connor4312 opened this issue Dec 14, 2016 · 2 comments

Comments

@connor4312
Copy link

connor4312 commented Dec 14, 2016

Hi. We worked on an updated Typo.js version, but its scope is a bit out from a simple fork; it's more of a wholesale port. General changelog:

  • It's now in TypeScript
  • Added support for WebWorkers in browsers
  • Uses the Faroo spell check for much faster results (<1ms even for long words!) and arguably higher quality ones
  • It's currently quite messy as I was playing around with ideas and benchmarks, but we can get it cleaned up...

I wanted to ask if you're interested in merging this back in to make "typo.js 2.0" or if you're happy as is 😄

Cheers,
Connor

@cfinke
Copy link
Owner

cfinke commented Dec 26, 2016

Wow! Although I don't think that moving Typo.js to TypeScript is in the roadmap, I am intrigued by the Faroo spell check. Any advice for implementing it in vanilla JS?

@connor4312
Copy link
Author

Sorry for the late reply, holidays and stuff 😛

You should mostly be able to strip the type annotations and have it work in ES6. If you want to support non-ES6 platforms without a transpiler you'd have to swap out many of the constructs/keywords too, but for the most part it should be a 1:1 port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants