Async suggest #45
Open
Async suggest #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes suggest operating asynchroniously, providing _much_ faster performance, much smaller memory use, and allowing to stop a suggestion search midway. suggest : function (word, limit, doneFunc, progressFunc) - returns undefined - doneFunc (if given) will be called (with the results array) once the search is done - progressFunc (if given) will be called (with the new match and the array of all matches so far) whenever a new match is found in the search - if progressFunc returns===false the current search will be aborted - calling suggest without parameters will abort a current search if running See a working sample in https://plnkr.co/edit/0y1wCHXx3k3mZaHFOpHT
This was referenced Sep 4, 2016
|
To be honest, at this point, there are so many commits and no clear documentation of each commit that I would feel very uneasy merging in these changes. |
|
yeah complicated but work very well ... (and documented) I wrote this for CodeMirror, without async there is an unacceptable wait between pressing the right click and getting the results. see the gist here: https://gist.github.com/kofifus/4b2f79cadc871a29439d919692099406 anyways .. |
|
Personally, I don't inspect every commit when review a PR. I check "Files changed" tab only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option of running suggest asynchronously allowing updating the display with results as they come, and stopping a suggestion search midway. Also provides much faster performance and smaller memory use on both synchronous and asynchronous suggests.
The suggest function can now be called in one of three ways:
suggest(word, limit [=5])
suggest(word, limit [=5], doneFunc, progressFunc) where either doneFunc or progressFunc are defined
suggest()
Other changes:
See a working sample in plunkr