Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for unified value/type case syntax #140

Open
lucaswerkmeister opened this issue Sep 7, 2017 · 2 comments
Open

Add support for unified value/type case syntax #140

lucaswerkmeister opened this issue Sep 7, 2017 · 2 comments
Labels
feature
Milestone
Next release

Comments

@lucaswerkmeister
Copy link
Member

See eclipse-archived/ceylon#4402.
@lucaswerkmeister lucaswerkmeister added this to the Next release milestone Nov 19, 2017
lucaswerkmeister added a commit that referenced this issue Sep 9, 2018
@lucaswerkmeister
Update for changes to MatchCase
1cea49d 
A MatchCase now accepts a MatchList, not an ExpressionList, as part of
the new unified syntax for type and expression cases; this is a minimal
patch just to get the code to compile again. Full support for the new
match syntax is subject of #140.
@sadmac7000
Copy link

sadmac7000 commented Sep 23, 2018 •
edited

I encountered this today. Could this be part of this issue?

Exception in thread "main" ceylon.language.AssertionError "Assertion failed
        violated nonempty cases
                = concatenate(CeylonIterable(caseTypes.types), CeylonIterable(caseTypes.baseMemberExpressions).narrow<JBaseMemberExpression>())
                    .sort(byIncreasing(compose(Token.tokenIndex, JNode.token)))"
        at ceylon.ast.redhat.caseTypesToCeylon_.caseTypesToCeylon(CaseTypes.ceylon:31)

@lucaswerkmeister
Copy link
Member Author

Likely, though I’m not sure why. I first thought perhaps the parser now leaves types and baseMemberExpressions empty, but my own tests, including parser tests, still pass…

@lucaswerkmeister lucaswerkmeister changed the title Add suport for unified value/type case syntax Add support for unified value/type case syntax Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
2 participants
@sadmac7000 @lucaswerkmeister