Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleVersionDetails should have nativeBackends #129

Open
gavinking opened this issue Oct 26, 2015 · 12 comments
Open

ModuleVersionDetails should have nativeBackends #129

gavinking opened this issue Oct 26, 2015 · 12 comments
Assignees
Labels
Milestone

Comments

@gavinking
Copy link
Member

The ModuleVersionDetails class should have an attribute that tells me what are the supported Backends.

@quintesse would you please take a look at this. Thanks.

@quintesse
Copy link
Member

I don't think I can do this before the deadline you set for a wednesday release. What's the specific reason you need this feature? I'd think that knowing there is an implementation (native or not) would be sufficient?

@quintesse
Copy link
Member

Ah wait you linked another issue.

@gavinking
Copy link
Member Author

I want to automatically add native annotations on the import statements. I already have a branch of the IDE which implements this, but I can't get the information I need from a module query.

@quintesse
Copy link
Member

But couldn't you , for now, use the fact that a query for JVM + JS only returns one or the other for native modules?

@gavinking
Copy link
Member Author

Well sure I guess in principle I could do it with two queries, but that would make something that is already too slow now twice as slow.

@quintesse
Copy link
Member

Well I mean that if somebody is putting in an import statement we have to retrieve the artifacts anyway, right? So the moment you retrieve them you can check which ones you got. That shouldn't involve any queries AFAICT.

@gavinking
Copy link
Member Author

No, because as-per the resolution to #128, it only sends me the artifacts I asked for. It doesn't tell me that the module also has other artifacts available.

@quintesse
Copy link
Member

But that's what I mean, you'd normally ask for both artifacts, right?
Because I see two situations:

  • you have a module marked native("xxx") so you only ask for artifact XXX and don't have to worry about putting native on any imports
  • the module is cross-platform so you ask for both JVM and JS (*) and then look at which you got (you either get none, one or both)

THat should be enough information, right?

(*) well, it also depends on which backends you have enabled in the IDE I guess.

@gavinking
Copy link
Member Author

But that's what I mean, you'd normally ask for both artifacts, right?

No, I don't, because I want to get a filtered list of modules. Instead I ask for only the modules that are compatible with at least one of the enabled backends.

@gavinking
Copy link
Member Author

@quintesse Note that I can have a native import in a cross-platform module, and I might not have both backends enabled.

@gavinking
Copy link
Member Author

Reassigning to 1.3 because I think I can live without this for now.

@gavinking gavinking modified the milestones: 1.3, 1.2 Oct 26, 2015
@quintesse
Copy link
Member

Note that I can have a native import in a cross-platform module.

Yes, that was the second bullet point I mentioned above.

No, I don't, because I want to get a filtered list of modules. Instead I ask for only the modules that are compatible with at least one of the enabled backends.

I'm not sure I understand. If you ask for the list of modules that are compatible with either JVM or JS then you have your answer right there, don't you? Some of the modules will have JVM artifacts, some JS and some both. It would seem to me that's enough information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants