Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the actual output repo in default list of input repos #119

Open
FroMage opened this issue Apr 20, 2015 · 2 comments
Open

Use the actual output repo in default list of input repos #119

FroMage opened this issue Apr 20, 2015 · 2 comments
Labels
Milestone

Comments

@FroMage
Copy link
Member

FroMage commented Apr 20, 2015

Right now ./modules gets added to the default input repo list even when we change the output repo with --out. I think the output repo should be used in the default input repo list, whether defaulted or specified. But if we specify it, we should use what the user specified, not ./modules.

If the user wants both his output repo and ./modules he can add it manually.

@FroMage FroMage added the BUG label Apr 20, 2015
@FroMage FroMage added this to the 1.3 milestone Apr 20, 2015
@quintesse
Copy link
Member

I'm not sure I agree. To me currently all ceylon commands that deal with repositories, regardless if they have an --out option or not look up any modules they need from ./modules (unless overridden by --rep). That the compilers have an --out option, to me, only changes where the output module should be written to, it should IMO not affect where it looks up modules.

So in short, --rep affects the lookup of modules, -out affects where the output gets written.

(Even if this explanation is not entirely correct technically speaking I think it will cause the least surprises, the --out option affecting lookup does)

@FroMage
Copy link
Member Author

FroMage commented Apr 20, 2015

Well, it really depends. IMO we add the output repo to the default list of input repos, which makes sense. But that should be the output repo, and not ./modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants