Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom annotations to deployment #211

Open
alen-z opened this issue Jun 3, 2023 · 3 comments
Open

Add custom annotations to deployment #211

alen-z opened this issue Jun 3, 2023 · 3 comments

Comments

@alen-z
Copy link

alen-z commented Jun 3, 2023

Add ability to add custom annotations to deployment, e.g. sidecar.istio.io/inject: "false" would be valuable if deployed in namespace where sidecar injection is enabled. CSR deployment shouldn't have a sidecar.

@AlexyPulivelil
Copy link

In an another issue : cert-manager/cert-manager#4646 (comment) it's mentioned to add in podlabels, but it's showing error realed to Helm. Using v1.12.3

@alen-z
Copy link
Author

alen-z commented Sep 21, 2023

No custom labels can be added.

Deployment:

labels:
{{ include "cert-manager-istio-csr.labels" . | indent 4 }}

Template:

{{- define "cert-manager-istio-csr.labels" -}}
app.kubernetes.io/name: {{ include "cert-manager-istio-csr.name" . }}
helm.sh/chart: {{ include "cert-manager-istio-csr.chart" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- end -}}

@KipsasJaujoj
Copy link

Another use case is adding annotations for prometheus scrape jobs. Now only scraping via service is possible which is not acceptable for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants