Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates getting started doc to include new expected istiod output #146

Closed
wants to merge 1 commit into from
Closed

Updates getting started doc to include new expected istiod output #146

wants to merge 1 commit into from

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Apr 12, 2022 •
edited

A log line output changed in istio v1.13. This PR updates the expected output so to not cause confusion.

Fixes #145

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 12, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2022
@JoshVanL
Updates getting started doc to include new expected istiod output
8d9d953 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL mentioned this pull request Apr 12, 2022
Open
@JoshVanL
Copy link
Contributor Author

Documentation has now been moved to cert-manager.io

/close

1 similar comment
@JoshVanL
Copy link
Contributor Author

Documentation has now been moved to cert-manager.io

/close

@jetstack-bot
Copy link
Contributor

@JoshVanL: Closed this PR.

In response to this:

Documentation has now been moved to cert-manager.io

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

@JoshVanL: Closed this PR.

In response to this:

Documentation has now been moved to cert-manager.io

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to use Istio-CSR in istio(1.13.*)
3 participants
@JoshVanL @jetstack-bot @irbekrm