Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Test Cleanup #171

Open
SgtCoDFish opened this issue Jan 9, 2024 · 1 comment
Open

E2E Test Cleanup #171

SgtCoDFish opened this issue Jan 9, 2024 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@SgtCoDFish
Copy link
Member

The current e2e test runner hasn't been updated for some time, and has several issues:

  1. Old versions being tested
  2. Limited ability to vary tested Kubernetes / cert-manager versions
  3. In-script implementations of dependency provisioning (better to use make / makefile modules)
  4. e2e Suite is a regular go test with no compile flags, so go test ./... in the root of the repo fails

The minimum we should do is bump the versions being used, but it'd be worth changing this more widely. Binary dependencies (kubectl, etc) can be provisioned in make, and the gold standard would be for the kind cluster to be created in Go code when the test is set up.
@SgtCoDFish SgtCoDFish added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 9, 2024
@SgtCoDFish
Copy link
Member Author

There's also an error being printed in logs:

ERROR: unknown flag: --name

(taken from this test output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtCoDFish