Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venafi Certificate Valid Date #6898

Open
Guitarkalle opened this issue Apr 12, 2024 · 0 comments
Open

Venafi Certificate Valid Date #6898

Guitarkalle opened this issue Apr 12, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Guitarkalle
Copy link

Is your feature request related to a problem? Please describe.
I am trying to figure out if it was possible to request a certificate from Venafi with a specific End date, not use the CA defaults.
I browsed the code and here it seems the duration parameter is not really used:

func (v *Venafi) buildVReq(csrPEM []byte, duration time.Duration, customFields []api.CustomField) (*certificate.Request, error) {

Where it should be added to the vclient request: https://github.com/Venafi/vcert/blob/039d25df38a3f6ca5b1addc934824c5df633ff35/pkg/certificate/request.go#L65

Describe the solution you'd like
Pass duration to the vclient Request (maybe

req := certificate.NewRequest(cert)
? )

Describe alternatives you've considered
None

Additional context
None

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants