Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client-side rate-limiting to be disabled #6890

Open
wallrj opened this issue Apr 9, 2024 · 0 comments
Open

Allow client-side rate-limiting to be disabled #6890

wallrj opened this issue Apr 9, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@wallrj
Copy link
Member

wallrj commented Apr 9, 2024

In cert-manager/website#1458 I attempted to disable client-side rate-limiting of API requests,
by setting kubernetesAPIQPS: -1 in the controller config.
It should be possible, but -1 was rejected by the config validation function.

config:
  apiVersion: controller.config.cert-manager.io/v1alpha1
  kind: ControllerConfiguration
  kubernetesAPIQPS: -1
  kubernetesAPIBurst: -1
kubectl logs -n cert-manager cert-manager-f4948ff9-6sfm2

E0409 13:34:03.843673 1 main.go:39] "error executing command" err="error validating flags: [invalid value for kube-api-burst: -1 must be higher than 0, invalid value for kube-api-qps: -1 must be higher than 0]" logger="cert-manager"

FluxCD have implemented a mechanism to detect whether API Fairness and Queuing is enabled by the API server,
and disable the client-side rate-limiting in that case:

Kubernetes client-go are also considering ways to disable the client-side rate limiter when server-side rate limiting is enabled:

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants