Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicts in the attributes of the opensearch schemas #3469

Closed
psaiz opened this issue Nov 22, 2023 · 2 comments · Fixed by #3630
Closed

Conflicts in the attributes of the opensearch schemas #3469

psaiz opened this issue Nov 22, 2023 · 2 comments · Fixed by #3630
Assignees
@psaiz

Comments

@psaiz
Copy link
Contributor

psaiz commented Nov 22, 2023

The schema of opendata defines 3 objects (records, glossary and docs). All these obejcts are stored under indices like record-<type>. The searches are done in all the indices.

There are some conflicts in the attributes defined for those objects:

  • Experiment:
Type | Index names
-- | --
keyword | records-docs-v1.0.0-1700664727, records-record-v1.0.0-1700664727
object | records-glossary-term-v1.0.0-1700664727
  • Collections:
keyword | records-record-v1.0.0-1700664727
-- | --
object | records-docs-v1.0.0-1700664727, records-glossary-term-v1.0.0-1700664727

It would be better to be consistent, and store the attribute with the same type for all the objects
@psaiz psaiz mentioned this issue Jan 22, 2024
Merged
@psaiz
Copy link
Contributor Author

psaiz commented Jan 26, 2024

Most of the issues have been addressed. The one left is for collections. That one is a bit trickier, so it deserves its own PR

@psaiz psaiz self-assigned this Jan 26, 2024
@psaiz
Copy link
Contributor Author

psaiz commented Feb 2, 2024

For the record, the one of experiment has also been fixed (it used to be an array of dictionaries for glossaries, and an array for docs and records)

@psaiz psaiz linked a pull request Apr 23, 2024 that will close this issue
schema: make the field 'collections' compatible between records and documents #3630
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psaiz psaiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schema: make the field 'collections' compatible between records and documents psaiz/opendata.cern.ch
1 participant
@psaiz