Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest go versions don't (yet?) whitelist "-fms-extensions" as an acceptable cgo CFLAGS value #373

Open
nshalman opened this issue Feb 16, 2018 · 0 comments
Open

Latest go versions don't (yet?) whitelist "-fms-extensions" as an acceptable cgo CFLAGS value #373

nshalman opened this issue Feb 16, 2018 · 0 comments

Comments

@nshalman
Copy link
Member

Issue Description

invalid flag in #cgo CFLAGS: -fms-extensions when building our zfs component

Steps to Reproduce (if applicable):

Try to build with go 1.8.7 or 1.9.4 without setting CGO_CFLAGS_ALLOW="-fms-extensions" in the build environment.

There will be a workaround in our nix expressions, but that might be confusing for developers.

Acceptance Criteria (how do we know when this is done?)

Related Tickets

golang/go#23672

Additional Info

Output of uname -a:
Environment (physical, VM, cloud provider, etc.):
Other Relevant Info:
nshalman added a commit that referenced this issue Feb 16, 2018
@nshalman
workaround for #373
2bbf925
@nshalman nshalman changed the title Latest go version don't (yet?) whitelist "-fms-extensions" as an acceptable cgo CFLAGS value Latest go versions don't (yet?) whitelist "-fms-extensions" as an acceptable cgo CFLAGS value Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshalman