Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/tcp status checks should not embed address in definition #305

Open
mmlb opened this issue Jul 26, 2016 · 1 comment
Open

http/tcp status checks should not embed address in definition #305

mmlb opened this issue Jul 26, 2016 · 1 comment

Comments

@mmlb
Copy link
Member

mmlb commented Jul 26, 2016

Issue Description

The httpstatus arg has a required url argument, httpstatus checker is passing this straight through to http.NewRequest. This makes no sense since there will likely be > 1 nodes running the service and the ip can't be known at service definition time. See discussion https://gitter.im/cerana/cerana?at=579798fa8fb4820a4665e4ef

Similar situation exists in tcp health checker.

@bbickerton
Copy link
Member

For now, define urls with localhost. Once networking is complete, we can try to be more clever and correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants