Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We can sometimes use trtype before it was assigned #643

Closed
gbregman opened this issue May 14, 2024 · 0 comments · Fixed by #655
Closed

We can sometimes use trtype before it was assigned #643

gbregman opened this issue May 14, 2024 · 0 comments · Fixed by #655
Assignees

Comments

@gbregman
Copy link
Contributor

In list_connections_safe() when we parse the qp information we might get an exception before getting to the assignment of trtype. But, as we continue and generate a connection object we use trtype anyway, even if it wasn't assigned. We should initialize trtype so it will have a valid value even in case of an exception.

@gbregman gbregman self-assigned this May 14, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 19, 2024
Fixes ceph#643

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 19, 2024
Fixes ceph#643

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
baum pushed a commit to baum/ceph-nvmeof that referenced this issue May 20, 2024
Fixes ceph#643

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant