Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the processing of io errors in namespace get_io_stats #641

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix the processing of io errors in namespace get_io_stats #641

merged 1 commit into from
May 15, 2024

Conversation

gbregman
Copy link
Contributor

Fixes #639

@gbregman
Fix the processing of io errors in namespace get_io_stats.
2d446e9 
Fixes ceph#639

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
@gbregman gbregman self-assigned this May 13, 2024
@gbregman gbregman requested a review from caroav May 13, 2024 18:20
@gbregman
Copy link
Contributor Author

Made sure there is backward compatibility. Used an old CLI with a new gateway and made sure the get_io_stats command works. The only issue is that the old CLI didn't really know about the value of the IO error field, so the output of this field is ugly:

IO Error                │ [10, 6, 102, 97, 105, 108, 101, 100, 16, 10, 10, 10, 110, 118, 109, 101, 95, 101, 114, 114, 111, 114, 16, 11, 10, 10, 115, 99, 115, 105, 95, 101, 114, 114, 111, 114, 16, 12, 10, 5, 110, 111, 109, 101, 109, 16, 13, 10, 10, 109, 105, 115, 99, 111, 109, 112, 97, 114, 101, 16, 14, 10, 18, 102, 105, 114, 115, 116, 95, 102, 117, 115, 101, 100, 95, 102, 97, 105, 108, 101, 100, 16, 15, 10, 7, 97, 98, 111, 114, 116, 101, 100, 16, 16, 10, 9, 97, 105, 111, 95, 101, 114, 114, 111, 114, 16, 17]

but this never actually worked in the old CLI anyway. We just didn't see it as the old gateway couldn't handle a reply with IO errors.

@gbregman gbregman merged commit 3d57958 into ceph:devel May 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroav caroav caroav approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namespace get_io_stats is failing sometimes
2 participants
@gbregman @caroav