Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Docker Swarm / Repackage as Docker Plugin #3769

Open
s4ke opened this issue Apr 24, 2023 · 22 comments
Open

Add Support for Docker Swarm / Repackage as Docker Plugin #3769

s4ke opened this issue Apr 24, 2023 · 22 comments
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs dependency/docker-swarm enhancement New feature or request keepalive This label can be used to disable stale bot activiity in the repo VolunteersRequired Tag for issues where we need a volunteer to pick an issue

Comments

@s4ke
Copy link

s4ke commented Apr 24, 2023

Describe the feature you'd like to have

Recently published Docker 23.0.0 added CSI support for Swarm mode so it is possible to use CSI drivers with it but they have to be packaged as Docker plugin.

What is the value to the end user? (why is it a priority?)

Docker Swarm users would gain the ability to use ceph in Docker Swarm via CSI instead of relying on bind mounting volumes.

How will we know we have a good solution? (acceptance criteria)

  • Packaged the CSI driver for Docker.
  • Able to create a cluster volume via the docker cli

Additional context

You can find more information here. Hetzner CSI has already merged a PR that adds support

@Rakshith-R Rakshith-R added enhancement New feature or request VolunteersRequired Tag for issues where we need a volunteer to pick an issue labels Apr 25, 2023
@nixpanic nixpanic added component/deployment Helm chart, kubernetes templates and configuration Issues/PRs dependency/docker-swarm labels May 1, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label May 31, 2023
@bluepuma77
Copy link

+1

@github-actions github-actions bot removed the wontfix This will not be worked on label Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Jul 4, 2023
@bluepuma77
Copy link

Still +1

@Madhu-1 Madhu-1 removed the wontfix This will not be worked on label Jul 6, 2023
@nixpanic
Copy link
Member

nixpanic commented Jul 6, 2023

Contributions from someone that has tested it on Docker Swarm are still welcome!

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Aug 5, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2023
@tyteen4a03
Copy link

tyteen4a03 commented Aug 23, 2023

+1

@miberecz
Copy link

I would also love to see this

@nixpanic
Copy link
Member

There seems some interest in this feature. Most of the regular Ceph-CSI contributors are not familiar with Docker Swarm, so it is not something that they easily can do.

Contributions from others that would like to see this feature made available are most welcome!

@s4ke
Copy link
Author

s4ke commented Sep 28, 2023

@nixpanic I would love to help out here at least with guidance, but sadly I don't have a working CEPH cluster to test this against. Any hints how to solve this (for dev at least)?

@nixpanic
Copy link
Member

nixpanic commented Sep 29, 2023 via email

@s4ke
Copy link
Author

s4ke commented Sep 29, 2023

Ah, you are proposing adapting this https://github.com/ceph/go-ceph/blob/9408dd58842306bca172192d320ea9cfab08065a/Makefile#L182 but leaving out the final testing step. Good idea, should work.

@s4ke
Copy link
Author

s4ke commented Oct 5, 2023

Even though this is closed as an issue, I guess we can keep the discussion here? I plan to work on this when I have time, but I don't know exactly when that will be.

@miberecz
Copy link

miberecz commented Oct 6, 2023

I do not see why this issue closed when its clearly should not be.
Definitely keep us posted with you progress, or if there anything what we can help with.

@Rakshith-R Rakshith-R added keepalive This label can be used to disable stale bot activiity in the repo and removed wontfix This will not be worked on labels Oct 6, 2023
@Rakshith-R
Copy link
Contributor

There seems some interest in this feature. Most of the regular Ceph-CSI contributors are not familiar with Docker Swarm, so it is not something that they easily can do.

Contributions from others that would like to see this feature made available are most welcome!

I'd like to second what @nixpanic mentioned in a comment above.

I've reopened the issue and added keep alive label to avoid it from closing again.

@s4ke
Copy link
Author

s4ke commented Oct 6, 2023

I 100% understand. That's why I am offering to help out. But as you know, time is a precious resource :). I will try to get some prototyping in, but that might not happen for a long time or it might happen over the weekend. I just don't know.

So to anyone of the Swarm fans - if you want to work on this (maybe with my help) - reach out to me or join our Swarm Fans discord over at https://devops.fan . Then we can join efforts :).

In general, I think that having a CEPH CSI provider for Swarm would be huge for anyone that is not on a cloud provider.

@s4ke
Copy link
Author

s4ke commented Oct 15, 2023

Leaving some notes of prelimiary investigation here:

The Docker volume plugin will require its own entrypoint as configuration needs to happen via environment variables with docker plugins. I have only found cephcsi.go which uses flags.

@miberecz
Copy link

Any news about this?

@s4ke
Copy link
Author

s4ke commented Dec 29, 2023

I sadly have not found the time to work on this yet.

@GiamBoscaro
Copy link

+1 would be awesome to have this

@Madhu-1 Madhu-1 reopened this Feb 28, 2024
@cdalvaro
Copy link

cdalvaro commented Mar 1, 2024

This would be amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs dependency/docker-swarm enhancement New feature or request keepalive This label can be used to disable stale bot activiity in the repo VolunteersRequired Tag for issues where we need a volunteer to pick an issue
Projects
None yet
Development

No branches or pull requests

9 participants