Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that worker kills child processes on systems supporting prctl. PR_SET_PDEATHSIG #6945

Closed
4 tasks done
matusvalo opened this issue Sep 5, 2021 · 3 comments · Fixed by #6946
Closed
4 tasks done

Comments

@matusvalo
Copy link
Member

matusvalo commented Sep 5, 2021

Checklist

  • I have checked the issues list
    for similar or identical bug reports.
  • I have checked the pull requests list
    for existing proposed fixes.
  • I have checked the commit log
    to find out if the bug was already fixed in the master branch.
  • I have included all related issues and possible duplicate issues in this issue
    (If there are none, check this box anyway).

Related Issues and Possible Duplicates

Related Issues

  • None

Possible Duplicates

  • None

Description

Documentation https://docs.celeryproject.org/en/master/userguide/workers.html#stopping-the-worker is outdated due merged PR #6942.

Suggestions

Documentation should mention that Celery worker main process running on systems supporting prctl. PR_SET_PDEATHSIG should be able to kill all child processes using SIGKILL signal.

@open-collective-bot
Copy link

Hey @matusvalo 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@matusvalo matusvalo added this to the 5.2 milestone Sep 5, 2021
@matusvalo matusvalo changed the title Mention that worker kills child processes on systems supporting prctl.PDEATHSIG Mention that worker kills child processes on systems supporting prctl. PR_SET_PDEATHSIG Sep 5, 2021
@auvipy
Copy link
Member

auvipy commented Sep 6, 2021

i should have suggest the document change in the PR which i forgot!

@matusvalo
Copy link
Member Author

matusvalo commented Sep 6, 2021

Yeah I will try to update the docs ASAP. It's not big deal just few sentences needs to be added/updated. I have added this bug just for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants