Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Now replace for more" continues unexpectedly #7

Open
cefn opened this issue Jul 16, 2017 · 0 comments
Open

"Now replace for more" continues unexpectedly #7

cefn opened this issue Jul 16, 2017 · 0 comments

Comments

@cefn
Copy link
Owner

cefn commented Jul 16, 2017

The awaitingPresent state is show either by "Place your Tag" and "Now Replace for More" depending on whether the recent tag is expected to be placed again.

Similarly "Lift and Replace for More" is switched for "Remove when Ready" if another 'tag place' isn't expected from the same player.

This logic should be coupled to awaitPresence() timeout, in common with the status of resetTag (which is waiting for the next tag to reset) and cardCache (which is waiting to see the same card again).

Currently it is only when you hit a 'missTemplate' that the "Remove when Ready" message appears. Ideally it should be one step before, when the final page of the ThroughSequence has presented its message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant