Corbridge Story issues

[cefn]

Really great to see so much progress on creating a real Corbridge story with the limited set of python objects provided by Avatap. Thanks @cheapjack and @gkboulter from your respective forks

Just wanted to feed back some extra thoughts, regards https://github.com/cefn/avatap/blob/master/python/stories/corbridgeRD.py

• Make sure any sack value you reference has a default value in the startSack - avoids possible bugs that the value isn't set, because somehow the person didn't visit the bit which sets it. (in fact I can't find this problem now, so I might have dreamed it)
• I think there is a bug in the use of page rather than missTemplate in the final node (uid ending). That's because it's actually a new beginning starting back at the entrance, with the the ending page being the miss template shown everywhere else. This is a correct use, but missTemplate will therefore give you the ending page.
• Be aware that a NodeFork without a page attribute will have a generic default message like "Choose from the following:". You can change this to be something you prefer.
• It's probably important to start adopting the convention that you don't rename files when you change them. That's why you have different repositories. Otherwise it will be hard to make sense of what has changed from each person's contribution, and git won't help. So the version you edit should still be called corbridge.py. If you feel that we (as a team) need a reference to the original version for some reason, or if you need a temporary copy locally, then copy it to some other file name, but keep working on corbridge.py so people can see what your changes are when you put them in your repo.

[cheapjack]

Thanks!

@Glenn so if you want to keep a reference version of @cefn original corbridge.py just Glenn$ cp corbridge.py corbridge_reference.py or something so its just for your own local reference copy so you don't need to add that to git it's just something useful for yourself.