Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash.js 3.0.1 missing #13638

Closed
olafcm opened this issue Dec 11, 2019 · 5 comments
Closed

Dash.js 3.0.1 missing #13638

olafcm opened this issue Dec 11, 2019 · 5 comments

Comments

@olafcm
Copy link
Contributor

olafcm commented Dec 11, 2019

npm autoupdate is enabled, see: https://cdnjs.com/libraries/dashjs
but version 3.0.1 (https://www.npmjs.com/package/dashjs) is missing, see: https://github.com/cdnjs/cdnjs/tree/5eba365ae67cfa323dbb69fe0c77cfc7eabb1955/ajax/libs/dashjs

Can this be resolved?
How does that work with the new cdnjs bot?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@MattIPv4
Copy link
Member

Hi there!

Thank you for making a new library request issue on cdnjs! 📦
Due to the massive number of requests we receive, it may be a while before one of our team get around to processing this request.

To help us with this, you can create the pull request to add the library yourself! 📥

Please take a read of our CONTRIBUTING.md file for a basic outline of how to make a library pull request and also our CONTRIBUTING-WIP.md file for more specific details of the cdnjs package.json file for each library.

Thank you very much for your help in keeping cdnjs up to date with libraries. 😄

@MattIPv4 MattIPv4 added the 📦 Update Request A request for a library to be manually updated label Dec 13, 2019
@olafcm
Copy link
Contributor Author

olafcm commented Dec 17, 2019

I think this library should just auto-update, how to analyze why the new cdnjs bot failed to add the new version of this library?

@MattIPv4
Copy link
Member

Auto-update config: https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/dashjs/package.json#L18-L25

Files in 3.0.0:

dash.all.debug.js             dash.all.min.js.map           dash.mediaplayer.debug.js.map dash.mss.debug.js             dash.mss.min.js.map           dash.protection.min.js        dash.reporting.debug.js.map
dash.all.debug.js.map         dash.d.ts                     dash.mediaplayer.min.js       dash.mss.debug.js.map         dash.protection.debug.js      dash.protection.min.js.map    dash.reporting.min.js
dash.all.min.js               dash.mediaplayer.debug.js     dash.mediaplayer.min.js.map   dash.mss.min.js               dash.protection.debug.js.map  dash.reporting.debug.js       dash.reporting.min.js.map

Files in 3.0.1:

dash.all.debug.js             dash.all.min.js.map           dash.mediaplayer.debug.js.map dash.mss.debug.js             dash.mss.min.js.map           dash.protection.min.js        dash.reporting.debug.js.map
dash.all.debug.js.map         dash.d.ts                     dash.mediaplayer.min.js       dash.mss.debug.js.map         dash.protection.debug.js      dash.protection.min.js.map    dash.reporting.min.js
dash.all.min.js               dash.mediaplayer.debug.js     dash.mediaplayer.min.js.map   dash.mss.min.js               dash.protection.debug.js.map  dash.reporting.debug.js       dash.reporting.min.js.map

These actually appear to be identical, so there is no reason the auto-update bot should've failed here and it shouldn't require manual intervention to resolve.

Any ideas @xtuc?

@MattIPv4 MattIPv4 added ☢️ Bug and removed 📦 Update Request A request for a library to be manually updated labels Dec 17, 2019
@xtuc
Copy link
Member

xtuc commented Jan 30, 2020

The bot added v3.0.1

@xtuc xtuc closed this as completed Jan 30, 2020
@olafcm
Copy link
Contributor Author

olafcm commented Jan 30, 2020

Perfect :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants