Setting the window title on tab switches

[manveru]

So after diving into the source for a bit, i found that one can not only set the custom config, but also custom hooks, and so I came up with this little snippet to set the window title to what the shell desires.

customCreateTermHook :: TMState -> Terminal -> IO ()
customCreateTermHook tmState vteTerm = do
  void $ onTerminalWindowTitleChanged vteTerm $ do
    maybeTitle <- terminalGetWindowTitle vteTerm
    let title = fromMaybe "shell" maybeTitle

    tmState <- readMVar tmState
    let win = tmState ^. lensTMStateAppWin

    windowSetTitle win title

What I couldn't figure out yet is what callback to use to also set the window title to the current tab title when you change tabs. I'd be very thankful for any ideas regarding that.

Also I think the above config might be a good default. I think most other other terminal emulators behave this way.

[cdepillabout]

Thanks for posting this. This sounds like it would be a good improvement.

I think the above config might be a good default. I think most other other terminal emulators behave this way.

Yeah, that sounds reasonable. Do you want to send a PR for this?

what callback to use to also set the window title to the current tab title when you change tabs

There really aren't that many callbacks yet. I've been adding them on an as-need basis when users request them.

Here's the four functions that deal with changing tabs. Would you want to send a PR adding a new callback here?

termonad/src/Termonad/Term.hs

Lines 136 to 152 in d0f8c9a

	focusTerm :: Int -> TMState -> IO ()
	focusTerm i mvarTMState = do
	note <- tmNotebook . tmStateNotebook <$> readMVar mvarTMState
	notebookSetCurrentPage note (fromIntegral i)
	altNumSwitchTerm :: Int -> TMState -> IO ()
	altNumSwitchTerm = focusTerm
	termNextPage :: TMState -> IO ()
	termNextPage mvarTMState = do
	note <- tmNotebook . tmStateNotebook <$> readMVar mvarTMState
	notebookNextPage note
	termPrevPage :: TMState -> IO ()
	termPrevPage mvarTMState = do
	note <- tmNotebook . tmStateNotebook <$> readMVar mvarTMState
	notebookPrevPage note

Although it sounds like if the window title functionality was available, you wouldn't personally need this hook here.