Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong channel for Watch MyTrades. C# #22295

Closed
skuvv opened this issue Apr 26, 2024 · 6 comments · Fixed by #22338 or #22358
Closed

Wrong channel for Watch MyTrades. C# #22295

skuvv opened this issue Apr 26, 2024 · 6 comments · Fixed by #22338 or #22358
Assignees

Comments

@skuvv
Copy link

skuvv commented Apr 26, 2024

Operating System

Windows 10

Programming Languages

No response

CCXT Version

4.3.6

Description

await exchange.WatchMyTrades

opens wrong channel 'orders' for trades:

Sending message: {"op":"subscribe","args":[{"instType":"SUSDT-FUTURES","channel":"orders","instId":"default"}]}
On message: {"event":"subscribe","arg":{"instType":"SUSDT-FUTURES","channel":"orders","instId":"default"}}

From docs:

{
    "op": "subscribe",
    "args": [
        {
            "instType": "USDT-FUTURES",
            "channel": "fill",
            "instId": "default"
        }
    ]
}

Code

  

@carlosmiei carlosmiei self-assigned this Apr 27, 2024
@carlosmiei
Copy link
Collaborator

Hello @skuvv,

Previously we didn't have the fill channel at bitget, but i think we can emulate it with orders because an event is sent every time an orders if filled, did you find a weird behavior with the current implementation of watchMyTrades ?
image

@carlosmiei
Copy link
Collaborator

(nonetheless I will try to update it)

@skuvv
Copy link
Author

skuvv commented Apr 27, 2024

At least OrderId is null when it cast raw info to MyTrade

@skuvv
Copy link
Author

skuvv commented May 2, 2024

@carlosmiei
CCXT Version:4.3.13
I see more info now, correct channel, but wrong orderId for trade (Bitget):
image

On message: {"action":"snapshot","arg":{"instType":"SCOIN-FUTURES","channel":"fill","instId":"default"},"data":[{"orderId":"1169836950450511873","tradeId":"1169836950740348929","symbol":"SETHSUSD","orderType":"market","side":"buy","price":"2922.03","baseVolume":"0.1","quoteVolume":"292.203","profit":"0","tradeSide":"open","posMode":"hedge_mode","tradeScope":"taker","feeDetail":[{"feeCoin":"SETH","deduction":"no","totalDeductionFee":"0","totalFee":"-0.00006003"}],"cTime":"1714636784253","uTime":"1714636784253"}],"ts":1714636784259}

@carlosmiei
Copy link
Collaborator

@skuvv Thanks for debugging it, will take a look as soon as possible

@carlosmiei
Copy link
Collaborator

@skuvv You're right, we had a typo in the Trade structure, but will be fixed asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants