Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Exchange: LBank #1271

Closed
jjhesk opened this issue Jan 15, 2018 · 12 comments
Closed

New Exchange: LBank #1271

jjhesk opened this issue Jan 15, 2018 · 12 comments
Assignees

Comments

@jjhesk
Copy link
Contributor

jjhesk commented Jan 15, 2018

url: https://www.lbank.info/
api doc: https://www.lbank.info/api/api-overview
api doc english: https://translate.google.com/translate?hl=en&sl=auto&tl=en&u=https%3A%2F%2Fwww.lbank.info%2Fapi%2Fapi-overview
based country: china
registered company: hong kong
detail: UNIT 04,7/F,BRIGHT WAY TOWER,NO.33 MONG KOK ROAD,KOWLOON HK.
telegram: https://t.me/LBankinfo

@kroitor kroitor self-assigned this Jan 15, 2018
@Deathamns
Copy link
Contributor

If no one has started implementing this, I might.

@noidasector56c20
Copy link

noidasector56c20 commented May 26, 2018

i want to get all ticker information in single api call but did not find any api or websokect . do anyone have suggestion?

@kroitor
Copy link
Member

kroitor commented May 26, 2018

@noidasector56c20

but did not find any api or websokect

WS is not supported yet. More about it here: #56

@garciapd
Copy link

hi @Deathamns @kroitor , i was checking the create market order, and it seems that in the price i have to put the cost (price * amount) so it is shown properly on the trade list but i'm not sure if the mapping is ok or even following other exchanges, because the amount when i create the order is in "quote currency" and it should be in base currency right?

@kroitor
Copy link
Member

kroitor commented May 19, 2022

@garciapd hi! We'll take a look, thanks for pointing it out! Are you using lbank or lbank2 btw?

@garciapd
Copy link

The issue I see is with lbank2, I'm using lbank2 for almost everything, but, there are some calls I still do with lbank because with lbank2 are not working

This work well (as far as i have seen) on lbank but not on lbank2

  • fetchOrderBook
  • fetchClosedOrders

@garciapd
Copy link

for the market orders, the price I think is not working as expected

and when fetch the order, the amount is on quote currency, which misleads also the "filled" calculation

@kroitor
Copy link
Member

kroitor commented May 19, 2022

@garciapd what's your version number of CCXT?

@garciapd
Copy link

1.82.94

@ttodua
Copy link
Member

ttodua commented May 21, 2022

hi @Deathamns @kroitor , i was checking the create market order, and it seems that in the price i have to put the cost (price * amount) so it is shown properly on the trade list but i'm not sure if the mapping is ok or even following other exchanges, because the amount when i create the order is in "quote currency" and it should be in base currency right?

can you mention , do both buy/sell misbehaves that way, or only sell? also, lets move into this topic: #13381 and reply there

@garciapd
Copy link

Hi, looks like only Buy Market Order misbehaves, i'm attaching a picture comparing the different cases in #13381

@garciapd
Copy link

@ttodua @kroitor also this 2 methods are not working, just FYI

fetchOrderBook
fetchClosedOrders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants