V2 Meta Issue

[shivupa]

This collects various comments during the development of v2 that have yet to be addressed

[shivupa]

          This is too much to go over in a code review but this reminds me of https://craftinginterpreters.com/representing-code.html#the-expression-problem: is it better for us to have properties as classes/programs as methods, or programs as classes/properties as methods?  This implements the former, since the latter has been a mess, and I think doing anything fancier (visitor) is not user-facing.

My one concern here is that this method is public. Will it be able to be made private so a user never has to specialize their code for their specific program? (Visibility is a breaking API change.)

Originally posted by @berquist in #1325 (comment)

[shivupa]

          This is the "same" in every parser.  The `atombasis.known_codes` can be abstracted if it's made a `classmethod`, then it becomes `cls.known_codes`, `getattr(cls, program)`, etc., which just leaves the return type.  Shouldn't the return type eventually be https://docs.python.org/3/library/typing.html#typing.Self?

Originally posted by @berquist in #1325 (comment)

          it feels like this might be a repeated paradigm can we factor this out? nothing to change right now

Originally posted by @shivupa in #1302 (comment)

[shivupa]

          This is too much to go over in a code review but this reminds me of https://craftinginterpreters.com/representing-code.html#the-expression-problem: is it better for us to have properties as classes/programs as methods, or programs as classes/properties as methods?  This implements the former, since the latter has been a mess, and I think doing anything fancier (visitor) is not user-facing.

My one concern here is that this method is public. Will it be able to be made private so a user never has to specialize their code for their specific program? (Visibility is a breaking API change.)

Originally posted by @berquist in #1325 (comment)

These functions are user facing mainly because they are static methods. They are technically user accessible.. but one would always just call parse which would call the correct function. We could change this to something like __CODENAME to make it private or something? Not really sure what the way forward here would be