Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor export functionality #178

Open
cbrnr opened this issue Oct 26, 2020 · 0 comments
Open

Refactor export functionality #178

cbrnr opened this issue Oct 26, 2020 · 0 comments

Comments

@cbrnr
Copy link
Owner

cbrnr commented Oct 26, 2020

Currently, the export machinery is a bit hacky and has grown over time. For example, there's one main function export_file in mainwindow.py, which calls specific export functions in model.py. However, these specific functions check file extensions differently with a ffilter parameter. The export_data function doesn't have this ffilter parameter and leaves the checking to functions defined in io.writers.

I think a consistent API would be nice, suggestions can be collected in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant