Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webinar or HowTo for contributors #1109

Closed
RocketRaccoon opened this issue Aug 8, 2016 · 4 comments
Closed

Webinar or HowTo for contributors #1109

RocketRaccoon opened this issue Aug 8, 2016 · 4 comments
Labels

Comments

@RocketRaccoon
Copy link

RocketRaccoon commented Aug 8, 2016

Hi,

Are you interesting in running some kind of webinar about TestNG architecture and development for those who would like to contribute in project?

@juherr
Copy link
Member

juherr commented Aug 14, 2016

Hi,

I'm not sure to understand what you propose, but any documentation that could help usage or development of TestNG are always welcome.
I think the best location to do it is in a CONTRIBUTING.md file (feel free to propose something via a pull-request).
About architecture, the wiki could be a good place too.

Thanks for your help.

@sskorol
Copy link
Contributor

sskorol commented Aug 15, 2016

I believe that @RocketRaccoon just asked main TestNG contributors (@cbeust and you @juherr) to provide a webinar, which explains TestNG core architecture for reducing an entry level to newbies, who is willing to become a committer.

And to be honest it seems a bit strange to propose a newbie creating a PR with architecture details.

@RocketRaccoon
Copy link
Author

@sskorol thanks for clarification, it's exactly that I wanted to say.

@juherr
Copy link
Member

juherr commented Aug 15, 2016

Ok, it is crystal clear now :)

The main source of internal documentation of TestNG is in @cbeust blog: https://www.google.com/?gws_rd=ssl#q=site:beust.com+testng and it is where I look for when I want to understand how/why something is working (or I disturb @cbeust :)).
The problem is TestNG is a 10 years old project with more/less activity in the last years; then the supposed architecture is not the actual one nor the one which should be in 2016 (and that's perfectly okay IMO).

About my experience, it often takes me a lot of time to find a fix for an issue because I don't know everything, and I have to rollback what I did when I understand the real cause.

In fact, if you want to contribute, go ahead and try something :) I always try to review pull-requests asap and help their authors to merge them.
For example, a good and easy start could be to review old pull-request (check if the problem still exists) and rework them (most of the time, a test is missing).
If you consider, like me, TestNG is a good project, and it should reborn, then feel free to propose any contributions, and I'll help you the best I can.


to be honest it seems a bit strange to propose a newbie creating a PR with architecture details

In the beginning, I didn't catch the question, and I agree with your point of view.
But I think too we could consider that a newbie is the best person who will be able to understand what a newbie need :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants