Use attr_writer when validations are not needed

[tagliala]

Offences found by fasterer

lib/axlsx/drawing/area_series.rb:49 Use attr_writer for writing to ivars.

lib/axlsx/drawing/axis.rb:89 Use attr_writer for writing to ivars.

lib/axlsx/drawing/bar_series.rb:48 Use attr_writer for writing to ivars.

lib/axlsx/drawing/bubble_series.rb:37 Use attr_writer for writing to ivars.

lib/axlsx/drawing/line_series.rb:49 Use attr_writer for writing to ivars.

lib/axlsx/drawing/scatter_series.rb:59 Use attr_writer for writing to ivars.
lib/axlsx/drawing/scatter_series.rb:70 Use attr_writer for writing to ivars.

lib/axlsx/workbook/worksheet/conditional_formatting.rb:64 Use attr_writer for writing to ivars.

lib/axlsx/workbook/worksheet/rich_text_run.rb:21 Use attr_writer for writing to ivars.

lib/axlsx/workbook/worksheet/worksheet_hyperlink.rb:36 Use attr_writer for writing to ivars.

caxlsx/lib/axlsx/drawing/area_series.rb

Lines 49 to 51 in 62b9d37

	def color=(v)
	@color = v
	end

caxlsx/lib/axlsx/drawing/axis.rb

Lines 89 to 91 in 62b9d37

	def color=(color_rgb)
	@color = color_rgb
	end

caxlsx/lib/axlsx/drawing/bar_series.rb

Lines 48 to 50 in 62b9d37

	def series_color=(v)
	@series_color = v
	end

caxlsx/lib/axlsx/drawing/bubble_series.rb

Lines 37 to 39 in 62b9d37

	def color=(v)
	@color = v
	end

caxlsx/lib/axlsx/drawing/line_series.rb

Lines 49 to 51 in 62b9d37

	def color=(v)
	@color = v
	end

caxlsx/lib/axlsx/drawing/scatter_series.rb

Lines 59 to 61 in 62b9d37

	def color=(v)
	@color = v
	end

caxlsx/lib/axlsx/drawing/scatter_series.rb

Lines 70 to 72 in 62b9d37

	def ln_width=(v)
	@ln_width = v
	end

caxlsx/lib/axlsx/workbook/worksheet/conditional_formatting.rb

Line 64 in 62b9d37

def rules=(v); @rules = v end

caxlsx/lib/axlsx/workbook/worksheet/rich_text_run.rb

Lines 21 to 23 in 62b9d37

	def value=(value)
	@value = value
	end

caxlsx/lib/axlsx/workbook/worksheet/worksheet_hyperlink.rb

Lines 36 to 38 in 62b9d37

	def target=(target)
	@target = target
	end

There are several options here:

1. For uniformity, setting those variables should keep using method=
2. For performance and code quality, those variables should use attr_writer
3. Some validations are missing

---

Comparison (IPS 2.6.10):
         attr_writer: 16354506.9 i/s
              method: 14390115.2 i/s - 1.14x  (± 0.00) slower

Comparison (IPS 3.2.2):
         attr_writer: 16205198.6 i/s
              method: 14282149.6 i/s - 1.13x  (± 0.00) slower

[github-actions]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
If you have any new information or updates please reply in order to keep the issue open.

[tagliala]

keep open

[github-actions]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
If you have any new information or updates please reply in order to keep the issue open.