Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support #13

Open
trajano opened this issue Nov 30, 2020 · 2 comments
Open

Add typescript support #13

trajano opened this issue Nov 30, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@trajano
Copy link

trajano commented Nov 30, 2020

Can you add typescript support?

@catdad catdad added the good first issue Good for newcomers label Dec 3, 2020
@catdad
Copy link
Member

catdad commented Dec 3, 2020

Users are not blocked from using plain javascript modules in a typescript project. I'll leave this open if someone is interested in adding proper typescript definitions. I don't know if I'll have time to do this myself any time soon.

@catdad catdad added the enhancement New feature or request label Dec 3, 2020
@trajano
Copy link
Author

trajano commented Dec 3, 2020

To start for people, I added a file heic-convert.d.ts that contains

declare module 'heic-convert';
declare module 'heic-decode';

This will prevent typescript warnings for the time being. Should be able to add a proper mapping from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants