Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read BatchInfo directly from colData ? #206

Open
catavallejos opened this issue Sep 29, 2020 · 2 comments
Open

Read BatchInfo directly from colData ? #206

catavallejos opened this issue Sep 29, 2020 · 2 comments

Comments

@catavallejos
Copy link
Owner

catavallejos commented Sep 29, 2020 •
edited

Rather than creating a new column in colData (e.g. colData(Data)$BatchInfo <- colData(Data)$MyBatch), we could have an extra parameter in BASiCS_MCMC that indicates the name of the relevant column.

What do you think @alanocallaghan ?
@catavallejos catavallejos changed the title Read BatchInfo directly from rowData ? Read BatchInfo directly from colData ? Sep 29, 2020
@alanocallaghan
Copy link
Collaborator

Yeah it's a reasonable change I just didn't bother before because it only removes that one line before running mcmc

@catavallejos
Copy link
Owner Author

true, let's leave it as it is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catavallejos @alanocallaghan