Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(legacy) [version 2.x] Some flags have dissapeared #391

Open
ebaynaud opened this issue Oct 22, 2021 · 8 comments
Open

(legacy) [version 2.x] Some flags have dissapeared #391

ebaynaud opened this issue Oct 22, 2021 · 8 comments

Comments

@ebaynaud
Copy link

Due to: lipis/flag-icons#860

@catamphetamine
Copy link
Owner

What?

@ebaynaud
Copy link
Author

ebaynaud commented Oct 22, 2021

Trying to understand why some of the flags have disappeared: https://flagicons.lipis.dev/

@ebaynaud ebaynaud changed the title Flags are not working anymore Some flags have dissapeared Oct 22, 2021
@catamphetamine
Copy link
Owner

This bug seems to be affecting version 2.x because it seems to have been using the now-removed flags from that lipis repo.
Users should migrate to the latest version 3.x then.

@catamphetamine catamphetamine changed the title Some flags have dissapeared (legacy) [version 2.x] Some flags have dissapeared Oct 25, 2021
@ebaynaud
Copy link
Author

Indeed, upgrading solves the issue.

@HasanCanUgurlu
Copy link

HasanCanUgurlu commented Dec 7, 2021

👋🏼 I've upgraded the package to version 3.0.0 but it seems like it's still trying to fetch the icons from lipis's library. I don't see any requests from country-flag-icons. It shows flags if I use flagUrl={...purecatamphetamine.github.io/country-flag-icons... prop. How can I debug this?

@catamphetamine
Copy link
Owner

I've upgraded the package to version 3.0.0 but it seems like it's still trying to fetch the icons from lipis's library.

It shouldn't.

@n8sabes
Copy link

n8sabes commented Dec 19, 2021

Indeed, I am seeing this as well. Dev and Production builds are pulling flags from purecatamphetamine.github.io.

@oddVlad
Copy link

oddVlad commented Dec 23, 2021

When updating from version 1.1.4 to the latest, I encountered the problem of "styles flying off". Default select and other. Can I somehow upgrade leaving the old view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants