Skip to content
This repository has been archived by the owner on Mar 15, 2023. It is now read-only.

[Feature]: TIFF interface should take a list of files #508

Open
2 tasks done
CodyCBakerPhD opened this issue May 9, 2022 · 4 comments
Open
2 tasks done

[Feature]: TIFF interface should take a list of files #508

CodyCBakerPhD opened this issue May 9, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@CodyCBakerPhD
Copy link
Member

CodyCBakerPhD commented May 9, 2022

What would you like to see added to nwb-conversion-tools?

We've seen a couple of times now that people break up a single consecutive ophys recording into multiple TIFF files less than 2GB each (unsure why threshold of 2GB is important).

While we can certainly add each of these source files as a different series to the file (current behavior), it would be nice if the TiffImagingInterface could take a list of files intended to belong to the same consecutive series.

Is your feature request related to a problem?

No response

What solution would you like?

TiffImagingInterface should be altered to take file_paths: Union[FilePathType, List[FilePathType]] instead of just file_path: FilePathType

then it loops over the list and runs file operations to the same series (unsure if roiextractors.write_imaging would support this, however)

OR to maintain complete back-compatibility, can keep as file_path and just extend the annotation support to lists.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@CodyCBakerPhD CodyCBakerPhD added the enhancement New feature or request label May 9, 2022
@CodyCBakerPhD
Copy link
Member Author

Depends on the MultiImagingExtractor that @weiglszonja is developing on roiextractors

@CodyCBakerPhD
Copy link
Member Author

Also the 2GB file size and non-memory mappable nature is a direct result of an option in the ScanImage software. The memory map aspect can be resolved with the new ScanImageTiffExtractor (and soon, ScanImageTiffInterface, which has quite a bit of extra metadata from the normal TiffImagingInterface).

@h-mayorquin
Copy link
Collaborator

Now that catalystneuro/roiextractors#127 is merged how this would work out?
The idea would be to add a new interface that concatenates multiple TiffImagingExtractor objects?

@CodyCBakerPhD
Copy link
Member Author

Yep. If a list of a single file path, then no need for MultiImaging under the hood. If more than one, splice them together with the MultiImaging so it behaves like a single ImagingExtractor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants