Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to getString/getArray need updating #775

Open
cameron1729 opened this issue Oct 6, 2023 · 0 comments
Open

Calls to getString/getArray need updating #775

cameron1729 opened this issue Oct 6, 2023 · 0 comments

Comments

@cameron1729
Copy link

After the lib upgrade, there's still a few calls to getArray that need to be changed to getOptionalArray

e.g.,:

And this one confuses me: https://github.com/sarahjcotton/moodle-auth_saml2/blob/MOODLE_39_STABLE/locallib.php#L209 - I don't get why it's called with 3 params.
sarahjcotton added a commit to sarahjcotton/moodle-auth_saml2 that referenced this issue Oct 6, 2023
@sarahjcotton
Issue catalyst#775: Fully use getOptionalx methods
9e3e3c8
sarahjcotton added a commit to sarahjcotton/moodle-auth_saml2 that referenced this issue Oct 6, 2023
@sarahjcotton
Issue catalyst#775: Fully use getOptionalx methods
f176e9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cameron1729