Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct save location for trained model #47

Open
parismic opened this issue Nov 7, 2019 · 1 comment
Open

Correct save location for trained model #47

parismic opened this issue Nov 7, 2019 · 1 comment

Comments

@parismic
Copy link

parismic commented Nov 7, 2019

It seems that the save path is incorrectly documented.

In the args the default dir is model_checkpoints and the README.md says models/bert/saves/Reuters/best_model.pt. I test it on SST-2 and the trained model was saved at model_checkpoints.

Or are these two different things?

See:

parser.add_argument('--save-path', type=str, default=os.path.join('model_checkpoints', 'bert'))

@Ashutosh-Adhikari
Copy link
Member

@parismic , yes that's an issue to be resolved. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants