Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce DateTime type-hint for 'from' and 'until' parameters #14

Open
caseyamcl opened this issue Feb 19, 2015 · 2 comments
Open

Enforce DateTime type-hint for 'from' and 'until' parameters #14

caseyamcl opened this issue Feb 19, 2015 · 2 comments
Milestone
Version 4.0

Comments

@caseyamcl
Copy link
Owner

In the Endpoint class, add \DateTime type-hints for all 'from' and 'until' parameters.

Also, remove the deprecated warnings (no longer necessary) and the EndpointTest test that tests to ensure the deprecated warnings are generated.
@caseyamcl caseyamcl added this to the Version 3.0 milestone Feb 19, 2015
@mjordan mjordan mentioned this issue Dec 6, 2017
Closed
@caseyamcl
Copy link
Owner Author

Use DateTimeInterface

@rudolfbyker rudolfbyker mentioned this issue Oct 9, 2018
Closed
@caseyamcl
Copy link
Owner Author

Whoops; didn;t mean to close this. This will have to be a v4.0 feature, since optional type-hints require PHP7.1 or newer.

@caseyamcl caseyamcl reopened this Oct 15, 2018
@caseyamcl caseyamcl modified the milestones: Version 3.0, Version 4.0 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4.0
Development

No branches or pull requests
1 participant
@caseyamcl