Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user merge\migrate between different users #651

Open
mojerro opened this issue Apr 7, 2022 · 8 comments · May be fixed by #809
Open

Support user merge\migrate between different users #651

mojerro opened this issue Apr 7, 2022 · 8 comments · May be fixed by #809
Assignees
@hsluoyz
Labels
enhancement New feature or request

Comments

@mojerro
Copy link

mojerro commented Apr 7, 2022

My situation:
User Joey has an account on casdoor registered by username\password. Next time he login through wechat web. And the casdoor register a new user for his wechat account.

Now, if casdoor can merge his old password account info and new wechat info, everything will be done.

Just an opinion, when merging two different users, first merge non-conflict fields, then if something conflicts, let the user choose to use the profiles in which account.
@casbin-bot
Copy link
Contributor

@Steve0x2a @seriouszyx @Abingcbc @ComradeProgrammer

@casbin-bot casbin-bot added the enhancement New feature or request label Apr 7, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Apr 7, 2022

@mojerro plz use English

@mojerro
Copy link
Author

mojerro commented Apr 7, 2022

In addition, after users log in with two different third-party accounts, Casdoor will have two accounts for the same person, and at this time, accounts need to be merged. When merging, merge non-conflicting fields first. If there is a conflict, there is no need to merge fields by fields. Choose directly to retain all information in which account.

@mojerro
Copy link
Author

mojerro commented Apr 7, 2022

Is there a roadmap for casdoor? @hsluoyz

@mojerro mojerro mentioned this issue Apr 9, 2022
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Jun 15, 2022

@ComradeProgrammer

@hsluoyz hsluoyz linked a pull request Jun 21, 2022 that will close this issue
Open
@leo220yuyaodog
Copy link
Member

Is similar with this pr #1464 ? Can auto merge different third-party account if they have the same email.

@hsluoyz
Copy link
Member

hsluoyz commented Feb 5, 2023

@leo220yuyaodog #1464 is the first method to merge. But if the 3rd-party provider doesn't have Email field, it will not work. So we need this PR: #809

This PR: #809 is already old and has a lot of conflicts. We need to propose a new PR to replace it

@leo220yuyaodog
Copy link
Member

OK, now I'm understand the issue. I'll propose a new PR to complete it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support merge user by admin ComradeProgrammer/casdoor
4 participants
@hsluoyz @mojerro @casbin-bot @leo220yuyaodog