Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable git clones of external modules due to performing full clone #3653

Open
spar-eag opened this issue Apr 5, 2024 · 0 comments
Open

Comments

@spar-eag
Copy link

spar-eag commented Apr 5, 2024

Currently when building casadi, and enabling support for external modules such as HiGHS, a full git clone, with all history, is performed. At least in the case of HiGHS, this leads to a much larger download than necessary, even failing sometimes due to networking errors.

Setting GIT_SHALLOW as described here https://cmake.org/cmake/help/latest/module/ExternalProject.html#git would solve the issue.

My current workaround is to do a shallow clone of the HiGHS repository myself (git clone --depth 1 --branch v1.6.0 https://github.com/ERGO-Code/HiGHS.git) and setting BUILD_HIGHS_GIT_REPO to point to my local copy.

I don't really see a reason to not use shallow clones by default in https://github.com/casadi/casadi/blob/main/CMakeLists.txt, as version history really shouldn't be needed, but one possibility would also be to add an option to use shallow clones or full clones like now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant